-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add holidays for South Africa #30
Conversation
23ec0b1
to
543050a
Compare
Thanks! Could you rebase on main, that way I can run the tests here |
543050a
to
8dec8a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you fix the failing tests on CI? Probably using $this->easter() will fix it.
There are 2 South Africa PRs, but with different results it seems. Could you both verify which one is correct? #32 |
8dec8a4
to
b0a0368
Compare
Both PRs looks to implement the same days. This one handles an additional edge case, where if a holiday rolls over from the Sunday to the Monday, it shouldn't be added if the Monday is already a Holiday (E.G if 25 Dec falls on a Sunday, it can't roll over to the Monday since the 26 Dec (the following Monday) will already be a holiday). |
Ah yes, the edge case that is covered here is indeed correct. This is the more complete implementation, and should be the one that gets merged. I'll close my PR :-) P.S. I'll try to remember to open a PR once we know what our general election date will be, as that is very likely to be proclaimed a public holiday as well. |
Thanks! |
No description provided.